Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string.findall APIs to pylibcudf #16825

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Add string.findall APIs to pylibcudf #16825

merged 5 commits into from
Sep 25, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Sep 18, 2024
@mroeschke mroeschke requested a review from a team as a code owner September 18, 2024 00:54
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue and removed pylibcudf Issues specific to the pylibcudf package labels Sep 18, 2024
@mroeschke mroeschke mentioned this pull request Sep 18, 2024
Open
@Matt711 Matt711 added the pylibcudf Issues specific to the pylibcudf package label Sep 19, 2024
wence-
wence- approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny doc nit

python/pylibcudf/pylibcudf/strings/findall.pyx Show resolved Hide resolved
@wence- wence- added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 20, 2024
@wence-
Copy link
Contributor

wence- commented Sep 20, 2024

I set to do not merge until #16813 is in, so we don't keep getting merge conflicts there. Once #16813, this is safe to merge.

@vyasr vyasr removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 23, 2024
Matt711
Matt711 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to merge when CI is unblocked

@Matt711
Copy link
Contributor

Matt711 commented Sep 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit 03c77c2 into rapidsai:branch-24.10 Sep 25, 2024
99 checks passed
@mroeschke mroeschke deleted the pylibcudf/strings/findall branch September 25, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@wence- wence- wence- approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @wence- @Matt711 @vyasr