-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually resolve conflicts in between branch-24.12 and branch-24.10 #16871
Manually resolve conflicts in between branch-24.12 and branch-24.10 #16871
Conversation
This is the changes that will be in the cudf-polars point release. --------- Co-authored-by: Thomas Li <[email protected]> Co-authored-by: David Wendt <[email protected]> Co-authored-by: brandon-b-miller <[email protected]> Co-authored-by: Vyas Ramasubramani <[email protected]> Co-authored-by: brandon-b-miller <[email protected]> Co-authored-by: Bradley Dice <[email protected]> Co-authored-by: Manas Singh <[email protected]> Co-authored-by: Manas Singh <[email protected]>
CI only tests 1.7
… branch-24.10-merge-24.08
Forward-merge branch-24.08 to branch-24.10
Adds stream ordering to the public join APIs: - `inner_join` - `left_join` - `full_join` - `left_semi_join` - `left_anti_join` - `cross_join` - `conditional_inner_join` - `conditional_left_join` - `conditional_full_join` - `conditional_left_semi_join` - `conditional_left_anti_join` - `mixed_inner_join` - `mixed_left_join` - `mixed_full_join` - `mixed_left_semi_join` - `mixed_left_anti_join` - `mixed_inner_join_size` - `mixed_left_join_size` - `conditional_inner_join_size` - `conditional_left_join_size` - `conditional_left_semi_join_size` - `conditional_left_anti_join_size` closes rapidsai#16792 follows up rapidsai#13744 Authors: - Basit Ayantunde (https://github.com/lamarrr) Approvers: - Paul Mattione (https://github.com/pmattione-nvidia) - Nghia Truong (https://github.com/ttnghia) - David Wendt (https://github.com/davidwendt) URL: rapidsai#16793
Adds a much-needed "best practices" page to the Dask cuDF documentation. Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Lawrence Mitchell (https://github.com/wence-) URL: rapidsai#16821
Contributes to rapidsai#15162 One question is that I notice that the libcudf `compute_column` takes an expression computed by a routine in https://github.com/rapidsai/cudf/blob/branch-24.10/python/cudf/cudf/core/_internals/expressions.py. Does this need to be moved to pylibcudf too? Authors: - Matthew Roeschke (https://github.com/mroeschke) - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: rapidsai#16760
The labeler was not updated for the move of pylibcudf to a separate package. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) URL: rapidsai#16868
This merge request exposes stream-ordering to the public-facing datetime APIs. - `extract_year` - `extract_month` - `extract_day` - `extract_weekday` - `extract_hour` - `extract_minute` - `extract_second` - `extract_millisecond_fraction` - `extract_microsecond_fraction` - `extract_nanosecond_fraction` - `last_day_of_month` - `day_of_year` - `add_calendrical_months` - `is_leap_year` - `days_in_month` - `extract_quarter` - `ceil_datetimes` - `floor_datetimes` - `round_datetimes` Follows-up rapidsai#13744 Closes rapidsai#16775 Authors: - Basit Ayantunde (https://github.com/lamarrr) Approvers: - Karthikeyan (https://github.com/karthikeyann) - Yunsong Wang (https://github.com/PointKernel) URL: rapidsai#16774
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a very very fast pass of post-merge review on this, as requested by @vyasr. I saw at least two issues, and I'll file a follow-up to branch-24.12 to address.
cudf-polars-polars-tests: | ||
needs: wheel-build-cudf-polars | ||
secrets: inherit | ||
uses: rapidsai/shared-workflows/.github/workflows/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be branch-24.12
.
# files in cudf_polars/pylibcudf", rather than "are there changes | ||
# between upstream and this branch which touch cudf_polars/pylibcudf" | ||
# TODO: is the target branch exposed anywhere in an environment variable? | ||
if [ -n "$(git diff --name-only origin/branch-24.10...HEAD -- python/cudf_polars/ python/cudf/cudf/_lib/pylibcudf/)" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 24.12
Description
This PR resolves merge conflicts seen in: #16866
Checklist