Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oldest deps for pyarrow & numpy #16883

Merged
merged 17 commits into from
Sep 24, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

We recently pinned our dask-expr version to 1.1.14: rapidsai/rapids-dask-dependency#64, that plus latest dask seems to be having a minimum requirement for pyarrow as 14.0.1. This is causing failures in our CI matrix while running tests with the oldest dependencies. This PR bumps the minimum pyarrow version in our oldest deps.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar self-assigned this Sep 24, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner September 24, 2024 01:59
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Sep 24, 2024
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Sep 24, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner September 24, 2024 15:06
@galipremsagar galipremsagar changed the title Update oldest deps for pyarrow Update oldest deps for pyarrow & numpy Sep 24, 2024
@github-actions github-actions bot removed Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Sep 24, 2024
@vyasr
Copy link
Contributor

vyasr commented Sep 24, 2024

It looks like the current installation in the conda testing scripts is too broad. Let's change test_python_common to accept the file_key as an argument that we can pass here, then make separate groups for test_python_cudf and test_python_other.

@galipremsagar
Copy link
Contributor Author

It looks like the current installation in the conda testing scripts is too broad. Let's change test_python_common to accept the file_key as an argument that we can pass here, then make separate groups for test_python_cudf and test_python_other.

Done 👍

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 73fa557 into rapidsai:branch-24.10 Sep 24, 2024
102 checks passed
@vyasr
Copy link
Contributor

vyasr commented Sep 24, 2024

Thanks Prem!

@galipremsagar
Copy link
Contributor Author

Thanks Prem!

Thank you for helping me in getting this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants