Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Report all unsupported operations for a query in cudf.polars #16960

Draft
wants to merge 1 commit into
base: branch-24.12
Choose a base branch
from
Draft

[WIP] Report all unsupported operations for a query in cudf.polars #16960

wants to merge 1 commit into from
+70 −1

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 1, 2024

Description

Closes #16690. The purpose of this PR is to list all of the unique operations that are unsupported by cudf.polars when running a query. The current approach is to create a new node (ErrorNode) in the IR when translating polars IR to cudf.polars IR if the translation step fails with a NotImplementedError. And then traverse the new tree and report where ErrorNodes occured to the user.

  1. Question: How to traverse the tree to report the error nodes? Should this be done upstream in Polars?
  2. Instead of traversing the query afterwards, we should probably catch each unsupported feature as we translate the IR.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added feature request New feature or request 5 - DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Oct 1, 2024
@Matt711 Matt711 self-assigned this Oct 1, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Matt711 Matt711

Labels
5 - DO NOT MERGE Hold off on merging; see PR for details cudf.polars Issues specific to cudf.polars feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Report all unsupported operations for a query in cudf-polars
1 participant
@Matt711