Support numba-cuda>=0.0.18
#17359
Open
Support numba-cuda>=0.0.18
#17359
+8
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not strictly necessary for 24.12. |
| @@ -196,7 +195,7 @@ class Aggregation: | |||
| # Handling UDF type | |||
| nb_type = numpy_support.from_dtype(kwargs['dtype']) | |||
| type_signature = (nb_type[:],) | |||
| ptx_code, output_dtype = cudautils.compile_udf(op, type_signature) | |||
| ptx_code, output_dtype = cudf.utils.cudautils.compile_udf(op, type_signature) | |||
There was a problem hiding this comment.
Config setting needs to be in place before numba.cuda is imported, which otherwise happens here during cython import
brandon-b-miller
added
feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way that cuDF puts numba into MVC mode for CUDA 12, using an env var rather than by applying a runtime patch to numba.