Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cudf_kafka now uses cuDF CMake export targets (CPM) #7674

Merged
merged 8 commits into from
Mar 25, 2021
Merged

cudf_kafka now uses cuDF CMake export targets (CPM) #7674

merged 8 commits into from
Mar 25, 2021

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Mar 22, 2021 •
edited
Loading

This integrates the changes from #7484 plus others required to get
cudf_kafka to build cleanly after the CMake refactoring of cudf

@robertmaynard robertmaynard requested review from a team as code owners March 22, 2021 23:43
@github-actions github-actions bot added CMake CMake build issue gpuCI libcudf Affects libcudf (C++/CUDA) code. labels Mar 22, 2021
kkraus14
kkraus14 reviewed Mar 23, 2021
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@robertmaynard
Copy link
Contributor Author

rerun tests

1 similar comment
@dillon-cullinan
Copy link
Contributor

rerun tests

@robertmaynard robertmaynard mentioned this pull request Mar 23, 2021
Merged
@robertmaynard robertmaynard force-pushed the fix/link_against_cpm_exports branch 2 times, most recently from e4724cd to 052a3fa Compare March 23, 2021 20:35
rapids-bot bot pushed a commit that referenced this pull request Mar 24, 2021
@robertmaynard
Fix/correct cudf installed package requirements (#7688)
b271c06 
This rolls up all the cudf changes from #7674 that are necessary for `libcudf_kafka` to build against an installed version of `branch-0.19`.

Authors:
  - Robert Maynard (@robertmaynard)

Approvers:
  - Keith Kraus (@kkraus14)

URL: #7688
@robertmaynard robertmaynard changed the title [WIP] Iterate on improving cudf exports and cudf_kafka usage cudf_kafka now uses cuDF CMake export targets (CPM) Mar 24, 2021
@mike-wendt
Copy link
Contributor

@robertmaynard Does this supersede #7484?

@codecov
Copy link

codecov bot commented Mar 24, 2021 •
edited
Loading

Codecov Report

Merging #7674 (9afbd7c) into branch-0.19 (7871e7a) will increase coverage by 0.24%.
The diff coverage is n/a.

❗ Current head 9afbd7c differs from pull request most recent head 70dace2. Consider uploading reports for the commit 70dace2 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7674      +/-   ##
===============================================
+ Coverage        81.86%   82.10%   +0.24%     
===============================================
  Files              101      101              
  Lines            16884    17080     +196     
===============================================
+ Hits             13822    14024     +202     
+ Misses            3062     3056       -6
Impacted Files Coverage Δ
python/cudf/cudf/core/buffer.py 83.63% <ø> (+4.39%) ⬆️
python/cudf/cudf/core/column/categorical.py 91.62% <ø> (+0.23%) ⬆️
python/cudf/cudf/core/column/column.py 87.51% <ø> (-0.25%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.09% <ø> (ø)
python/cudf/cudf/core/column/decimal.py 92.75% <ø> (-2.12%) ⬇️
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/column/lists.py 89.60% <0.00%> (-1.80%) ⬇️
python/cudf/cudf/utils/utils.py 85.06% <0.00%> (-0.38%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa9f5b...70dace2. Read the comment docs.

@robertmaynard
Copy link
Contributor Author

@robertmaynard Does this supersede #7484?

Yes

kkraus14
kkraus14 reviewed Mar 24, 2021
View reviewed changes
cpp/libcudf_kafka/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/libcudf_kafka/CMakeLists.txt Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 24, 2021
@kkraus14
Copy link
Collaborator

rerun tests

@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit eb92145 into rapidsai:branch-0.19 Mar 25, 2021
@robertmaynard robertmaynard mentioned this pull request Mar 25, 2021
Closed
@robertmaynard robertmaynard deleted the fix/link_against_cpm_exports branch March 25, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@mike-wendt mike-wendt mike-wendt approved these changes

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robertmaynard @dillon-cullinan @mike-wendt @kkraus14 @jdye64