[REVIEW] Upgrade clang to 11.1.0
#9716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
3 - Ready for Review
galipremsagar
requested review from
mythrocks and
nvdbaranec
and removed request for
a team
This was referenced Nov 17, 2021
raydouglass
approved these changes
Nov 17, 2021
This was referenced Nov 17, 2021
|
rerun tests |
1 similar comment
|
rerun tests |
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
galipremsagar
added
5 - Ready to Merge
|
rerun tests |
nvdbaranec
approved these changes
Nov 18, 2021
|
rerun tests |
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Nov 18, 2021
This upgrade is required to be in-line with: rapidsai/cudf#9716 Depends on: rapidsai/integration#390 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Ray Douglass (https://github.com/raydouglass) - Brad Rees (https://github.com/BradReesWork) URL: #1949
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Nov 18, 2021
This upgrade is required to be in-line with: rapidsai/cudf#9716 Depends on: rapidsai/integration#390 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Ray Douglass (https://github.com/raydouglass) URL: #4372
|
rerun tests |
galipremsagar
requested review from
trxcllnt and
cwharris
and removed request for
a team
ajschmidt8
approved these changes
Nov 18, 2021
|
Is this merged to |
Yes, will be merged with #9721 |
ajschmidt8
pushed a commit
to rapidsai/raft
that referenced
this pull request
Nov 22, 2021
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This upgrade is required to be in-line with: rapidsai/cudf#9716 Depends on: rapidsai/integration#390 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#4372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
clangto11.1.0. The version upgrade is required because,clang-11=11.0.0needslibclang-cpp11-11.0.0which needslibllvm11=11.0.1only. But for #9687 to work,numba-0.54has to be installed which needsllvmlite 0.37.*which requireslibllvm11 >=11.1.0,<11.2.0a0