Implement mixed equality/conditional joins #9917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted overhead to the purely conditional join code paths.
…er ahead of time.
…o much shared memory.
…r use in device code.
…_equality_conditional_joins
…rnel rather than inlining its logic in the pair_expression_equality comparator.
jrhemstad
reviewed
Jan 11, 2022
jrhemstad
reviewed
Jan 11, 2022
jlowe
reviewed
Jan 11, 2022
Open
11 tasks
jlowe
approved these changes
Jan 13, 2022
jrhemstad
approved these changes
Jan 18, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 19, 2022
Depends on #9917. Adds Java bindings for the libcudf mixed join APIs. A new MixedJoinSize class was added to track the size information returned for mixed joins. Authors: - Jason Lowe (https://github.com/jlowe) Approvers: - Robert (Bobby) Evans (https://github.com/revans2) URL: #9941
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 24, 2022
This PR is a follow-up to #9917 and should be merged after that PR. This resolves #9695 and resolves #5401. The implementation here is only a first pass, but in the interest of prioritizing a working feature for the upcoming release I'm postponing making various additional changes (including some breaking ones). Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Jason Lowe (https://github.com/jlowe) - David Wendt (https://github.com/davidwendt) - Robert Maynard (https://github.com/robertmaynard) URL: #10037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements mixed equality/inequality joins for inner, left, and full joins. This resolves #9696 and contributes to #5401. For the moment, all APIs are functional only, but an object-oriented API is planned to support caching of the hash table.