Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support structs for cudf::contains with column/scalar input #9929

Merged
merged 15 commits into from
Jan 15, 2022
Merged

Support structs for cudf::contains with column/scalar input #9929

merged 15 commits into from
Jan 15, 2022

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Dec 17, 2021 •
edited
Loading

This PR adds support for cudf::contains so we can check whether a structs column contains a scalar struct element.

Partially addresses #8965. This does not support checking if structs given in a structs column exist in another structs column. Such cases will be supported when the new data structure mentioned in #9413 is merged into cudf.

@ttnghia ttnghia added feature request New feature or request 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Dec 17, 2021
@ttnghia ttnghia self-assigned this Dec 17, 2021
@ttnghia ttnghia added the 0 - Blocked Cannot progress due to external reasons label Dec 17, 2021
@ttnghia ttnghia mentioned this pull request Dec 28, 2021
Closed
@ttnghia ttnghia marked this pull request as ready for review January 7, 2022 23:15
@ttnghia ttnghia requested a review from a team as a code owner January 7, 2022 23:15
@ttnghia ttnghia added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress 0 - Blocked Cannot progress due to external reasons labels Jan 7, 2022
@codecov

This comment has been minimized.

Sign in to view
@hyperbolic2346
Copy link
Contributor

Copyrights

@ttnghia ttnghia changed the title Support structs for cudf::contains Support structs for cudf::contains with column/scalar input Jan 11, 2022
mythrocks
mythrocks reviewed Jan 12, 2022
View reviewed changes
cpp/src/search/search.cu Outdated Show resolved Hide resolved
mythrocks
mythrocks reviewed Jan 12, 2022
View reviewed changes
cpp/src/search/search.cu Outdated Show resolved Hide resolved
mythrocks
mythrocks approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from a minor nitpick.

@ttnghia
Copy link
Contributor Author

ttnghia commented Jan 15, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7ff5f12 into rapidsai:branch-22.02 Jan 15, 2022
@ttnghia ttnghia deleted the contains_for_structs branch January 22, 2022 01:03
@ttnghia ttnghia mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@mythrocks mythrocks mythrocks approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu rgsl888prabhu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec

@rwlee rwlee Awaiting requested review from rwlee

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttnghia @hyperbolic2346 @mythrocks