add notebook tests, build.sh args #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
This reverts commit c27268e.
…rge version number
jameslamb
commented
Nov 4, 2024
jameslamb
changed the title
jameslamb
changed the title
jameslamb
commented
Nov 7, 2024
| # from the 'cugraph-gnn' repo and stop publishing them from | ||
| # the 'cugraph' / 'wholegraph' repos | ||
| #version=$(rapids-generate-version) | ||
| version="24.12.00a1000" |
There was a problem hiding this comment.
This (and other hard-coded 24.12.00a1000) is the weirdest part of this PR.
They're here to ensure that testing CI jobs are getting the packages built from this repo. Because there have been more 24.12 commits over in https://github.com/rapidsai/cugraph, I observed test jobs pulling in nightlies from rapidsai-nightly instead of the ones downloaded from S3, which was a cause of errors and accidental successes.
Setting this ridiculous number is safe because no packages are being published to any conda channels or the nightly PyPI index from this repo yet.
tingyu66
approved these changes
Nov 7, 2024
raydouglass
approved these changes
Nov 8, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53
This pulls over the remaining changes from that PR... thought that was easier than fixing the merge conflicts between that and recent PRs.
build.shchanges from Add CI for cuGraph-GNN #53 (mostly for interactive development)cugraph-pygandcugraph-dgltests inconda-python-tests(missed in add PR CI for cugraph-pyg and cugraph-dgl #59)Notes for Reviewers
I left other comments explaining these changes inline.