Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Remove NX Deprecation Warning Suppression #3706

Closed
nv-rliu opened this issue Jul 13, 2023 · 1 comment
Closed

[FEA]: Remove NX Deprecation Warning Suppression #3706

nv-rliu opened this issue Jul 13, 2023 · 1 comment
Assignees
@nv-rliu
Labels
feature request New feature or request
Milestone
23.08

Comments

@nv-rliu
Copy link
Contributor

nv-rliu commented Jul 13, 2023 •
edited
Loading

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium/Low

Please provide a clear description of problem this feature solves

The cugraph unit tests have been suppressing DeprecationWarnings from networkx calls. These can now be removed to clean up the tests.

Describe your ideal solution

These should now be removed
@nv-rliu nv-rliu added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jul 13, 2023
@nv-rliu nv-rliu added this to the 23.08 milestone Jul 13, 2023
@nv-rliu nv-rliu self-assigned this Jul 13, 2023
@nv-rliu nv-rliu mentioned this issue Jul 13, 2023
Closed
@BradReesWork BradReesWork removed the ? - Needs Triage Need team to review and classify label Jul 13, 2023
@nv-rliu nv-rliu mentioned this issue Jul 17, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 28, 2023
@nv-rliu
Promote Datasets to stable and clean-up unit tests (#3712)
836c27a 
Addresses #3675 and #3706 

This PR moves the `datasets` API from experimental to stable. Users can now do:

```python
from cugraph.datasets import karate

G = karate.get_graph()
```

The existing `experimental.datasets` package has been updated with the `promoted_experimental_warning_wrapper()`. All notebooks, docstrings, and unit test dependencies on `datasets` have been updated to use the stable API.

This PR also removes the networkx warning suppression from the unit tests.

Authors:
  - ralph (https://github.com/nv-rliu)
  - Naim (https://github.com/naimnv)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #3712
@nv-rliu
Copy link
Contributor Author

nv-rliu commented Jul 31, 2023

This was fixed with #3712

@nv-rliu nv-rliu closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nv-rliu nv-rliu

Labels
feature request New feature or request
Projects
None yet
Milestone
23.08
Development

No branches or pull requests
2 participants
@BradReesWork @nv-rliu