Updated git utils used by copyright.py for compatibility with current CI env #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t CI env, added debug prints.
…rrect branch to compare to.
…o get a list of files.
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #1325 +/- ##
============================================
Coverage 60.06% 60.06%
============================================
Files 67 67
Lines 3060 3060
============================================
Hits 1838 1838
Misses 1222 1222 Continue to review full report at Codecov.
|
|
rerun tests |
|
cc @teju85 for cuML |
raydouglass
approved these changes
Jan 11, 2021
teju85
added a commit
to teju85/cuml
that referenced
this pull request
Jan 12, 2021
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jan 21, 2021
This PR ports the corresponding fixes by @rlratzel for the cugraph [here](rapidsai/cugraph#1325) in order to re-enable copyright year checks in the CI scripts, over to cuML too. In the process I also took the liberty to port other changes that had been done on cugraph's copyright.py over to cuML too. ~~Just like the above PR, I'm leaving the copyright years unmodified to verify that the CI really works.~~ [Verified] Authors: - Thejaswi. N. S (@teju85) Approvers: - William Hicks (@wphicks) - AJ Schmidt (@ajschmidt8) - Dante Gama Dessavre (@dantegd) - Rick Ratzel (@rlratzel) URL: #3363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated git utils used by copyright.py for compatibility with current CI env, added debug prints.
NOTE: I'm intentionally not updating the copyright date on the changed file to test that the check is working in the actual CI environment here. Once verified, I'll change it from a draft PR and mark it ready for review.verified