Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling dataset.get_edgelist() returns a copy of an edge list instead of global #3777

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Aug 10, 2023

Closes #3421

This PR fixes a bug where get_edgelist() would return a global edge list, which causes any changes made to the first returned edge list to be reflected in subsequent calls to get_edgelist().

Now, get_edgelist() returns a copy of the dataframe stored by the Dataset object.

@nv-rliu nv-rliu added bug Something isn't working improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed bug Something isn't working labels Aug 10, 2023
@nv-rliu nv-rliu marked this pull request as ready for review August 10, 2023 16:29
@nv-rliu nv-rliu requested a review from a team as a code owner August 10, 2023 16:29
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit f1c0054 into rapidsai:branch-23.10 Aug 16, 2023
55 checks passed
@nv-rliu nv-rliu deleted the fix-global-edgelist branch August 16, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edgelist Returned from dataset.get_edgelist() is global
2 participants