-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds updates to build conda packages and CI testing for cugraph-nx
#3793
Adds updates to build conda packages and CI testing for cugraph-nx
#3793
Conversation
- networkx>=2.5.1 | ||
- networkx>=3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rapids-dependency-file-generator
is including both the networkx version used by cugraph-nx
, and the less-restrictive version independently used by other cugraph packages. This did not seem to be a problem when testing the env files (mamba
installed networkx version 3.1).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for the solvers, and I think should be fine for us. I use this environment to develop cugraph-nx
, so--as we discussed before--we just have to make sure the minimum nx version for cugraph-nx
is also supported by the other cugraph packages and all other packages in the environment. I don't expect this to be a nuisance.
…cugraph-nx conda recipe to 3.0, adds pip check to cugraph-nx conda recipe test.
…0-cugraph_nx_package
…0-cugraph_nx_package
Does this PR actually add nightly wheels and conda packages? If so, the README for |
…_url to all recipes, updates README to remove note about packages coming soon, updates comments and env vars in run_nx_tests.sh to match most recent changes.
…0-cugraph_nx_package
…UDA-independent packages (contained only in the CUDA 11 artifacts) are available, changed coverage check to use awk.
…0-cugraph_nx_package
…tead just builds CUDA-independent packages for both CUDA 11 and CUDA 12 to be included in both sets of artifacts.
… FIXME about .coveragerc
…jects either have or will need them soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/merge |
cugraph-nx
cugraph-nx
closes #3771
closes #3772
closes #3770
This PR adds updates to build new
cugraph-nx
wheels and conda packages, updates the CI scripts to test them, and also updates the auto-versioning script used during releases to also updatecugraph-nx
.This PR also cleans up some tech debt in
dependencies.yaml
and various conda recipes (added missing meta-data).