Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds updates to build conda packages and CI testing for cugraph-nx #3793

Merged

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Aug 15, 2023

closes #3771
closes #3772
closes #3770

This PR adds updates to build new cugraph-nx wheels and conda packages, updates the CI scripts to test them, and also updates the auto-versioning script used during releases to also update cugraph-nx.

This PR also cleans up some tech debt in dependencies.yaml and various conda recipes (added missing meta-data).

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 15, 2023
@rlratzel rlratzel added this to the 23.10 milestone Aug 15, 2023
@rlratzel rlratzel self-assigned this Aug 15, 2023
conda/recipes/cugraph-nx/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/cugraph-nx/meta.yaml Outdated Show resolved Hide resolved
python/cugraph-nx/pyproject.toml Outdated Show resolved Hide resolved
python/cugraph-nx/pyproject.toml Show resolved Hide resolved
python/cugraph-service/server/pyproject.toml Outdated Show resolved Hide resolved
Comment on lines 40 to +41
- networkx>=2.5.1
- networkx>=3.0
Copy link
Contributor Author

@rlratzel rlratzel Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rapids-dependency-file-generator is including both the networkx version used by cugraph-nx, and the less-restrictive version independently used by other cugraph packages. This did not seem to be a problem when testing the env files (mamba installed networkx version 3.1).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for the solvers, and I think should be fine for us. I use this environment to develop cugraph-nx, so--as we discussed before--we just have to make sure the minimum nx version for cugraph-nx is also supported by the other cugraph packages and all other packages in the environment. I don't expect this to be a nuisance.

ci/test_python.sh Outdated Show resolved Hide resolved
@eriknw
Copy link
Contributor

eriknw commented Aug 22, 2023

Does this PR actually add nightly wheels and conda packages? If so, the README for cugraph-nx should probably be updated, which currently says Nightly conda packages and pip wheels coming soon.

…_url to all recipes, updates README to remove note about packages coming soon, updates comments and env vars in run_nx_tests.sh to match most recent changes.
…UDA-independent packages (contained only in the CUDA 11 artifacts) are available, changed coverage check to use awk.
…tead just builds CUDA-independent packages for both CUDA 11 and CUDA 12 to be included in both sets of artifacts.
@rlratzel rlratzel marked this pull request as ready for review August 23, 2023 19:00
@rlratzel rlratzel requested review from a team as code owners August 23, 2023 19:00
Copy link
Contributor

@eriknw eriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit ec1e329 into rapidsai:branch-23.10 Aug 24, 2023
55 checks passed
@rlratzel rlratzel changed the title Adds updates to build wheel and conda packages for cugraph-nx Adds updates to build conda packages and CI testing for cugraph-nx Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
5 participants