[REVIEW] Cugraph dgl block improvements #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VibhuJawa
added
non-breaking
VibhuJawa
commented
Aug 18, 2023
python/cugraph-dgl/cugraph_dgl/dataloading/utils/sampling_helpers.py
Outdated
Show resolved
Hide resolved
VibhuJawa
changed the title
|
@tingyu66 , Could you take another look please before we try to get this in. |
tingyu66
requested changes
Aug 22, 2023
…/VibhuJawa/cugraph into cugraph_dgl_block_improvements
tingyu66
approved these changes
Aug 22, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #3784 and speeds up MFG creation by
3.5x.Todo:
Benchmarked on 6_462_743_488 edges with a batch size of
128on a 1 V100:Before PR Times:
After PR Times:
See link: https://gist.github.com/VibhuJawa/4852203f2e96de09d84d698af945682d
Profiling:
After PR: #3810
Profile of splitting df into tensors :