-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Shuffle Inputs Globally in cuGraph-PyG #4606
Closed
alexbarghi-nv
wants to merge
8
commits into
rapidsai:branch-24.12
from
alexbarghi-nv:pyg-shuffle-global
Closed
[FIX] Shuffle Inputs Globally in cuGraph-PyG #4606
alexbarghi-nv
wants to merge
8
commits into
rapidsai:branch-24.12
from
alexbarghi-nv:pyg-shuffle-global
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to pyg-shuffle-global
alexbarghi-nv
added
non-breaking
Non-breaking change
and removed
breaking
Breaking change
labels
Aug 8, 2024
tingyu66
approved these changes
Aug 23, 2024
This will be refactored and merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, inputs were only being shuffled locally. This PR uses NCCL to shuffle inputs across workers for better accuracy. It also exposes an option to disable global shuffling if desired.
Merge after #4641
Closes rapidsai/cugraph-gnn#19