Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed ci build_docs to just upload the xml so the cugraph-docs can create the docs #4662

Open
wants to merge 2 commits into
base: branch-24.12
Choose a base branch
from
Open

Changed ci build_docs to just upload the xml so the cugraph-docs can create the docs #4662

wants to merge 2 commits into from

Conversation

acostadon
Copy link
Contributor

… create the docs

@acostadon acostadon requested a review from a team as a code owner September 23, 2024 17:22
@github-actions github-actions bot added the ci label Sep 23, 2024
@acostadon acostadon marked this pull request as draft September 23, 2024 17:23
@acostadon acostadon added doc Documentation cuGraph labels Sep 23, 2024
@acostadon acostadon added this to the 24.10 milestone Sep 23, 2024
@acostadon acostadon marked this pull request as ready for review September 23, 2024 19:16
@acostadon acostadon added the non-breaking Non-breaking change label Sep 24, 2024
BradReesWork
BradReesWork requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 31 - 61 should also be redone. Since cugraph no longer builds the full set of Docs, there is no need to bring in the other external packages

@jameslamb jameslamb changed the title Changed ci build_docss to just upload the xml so the cugraph-docs can… Changed ci build_docss to just upload the xml so the cugraph-docs can create the docs Sep 27, 2024
jameslamb
jameslamb reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool, hadn't noticed this PR before! @ me any time you've addressed other comments and are ready for a ci-codeowners review (since I'd been helping over in https://github.com/rapidsai/cugraph-docs/pull/46)

@BradReesWork BradReesWork modified the milestones: 24.10, 24.12 Sep 30, 2024
@BradReesWork BradReesWork changed the base branch from branch-24.10 to branch-24.12 September 30, 2024 19:20
@jameslamb jameslamb changed the title Changed ci build_docss to just upload the xml so the cugraph-docs can create the docs Changed ci build_docs to just upload the xml so the cugraph-docs can create the docs Oct 14, 2024
@jameslamb jameslamb mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb left review comments

@BradReesWork BradReesWork BradReesWork requested changes

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/ci-codeowners

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ci cuGraph doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
24.12
Development

Successfully merging this pull request may close these issues.
3 participants
@acostadon @jameslamb @BradReesWork