-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CMake/C++ references to cugraph-ops #4744
base: branch-24.12
Are you sure you want to change the base?
Remove CMake/C++ references to cugraph-ops #4744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to remove ALL references to cugraph-ops
here? If so, there are many more:
git grep -i 'cugraph.*ops'
For example, all the uses of those now-removed CMake options in build scripts.
CI configs (click me)
cugraph/.github/workflows/build.yaml
Lines 79 to 81 in 050d524
extra-repo: rapidsai/cugraph-ops | |
extra-repo-sha: branch-24.12 | |
extra-repo-deploy-key: CUGRAPH_OPS_SSH_PRIVATE_DEPLOY_KEY |
cugraph/.github/workflows/build.yaml
Lines 103 to 105 in 050d524
extra-repo: rapidsai/cugraph-ops | |
extra-repo-sha: branch-24.12 | |
extra-repo-deploy-key: CUGRAPH_OPS_SSH_PRIVATE_DEPLOY_KEY |
cugraph/.github/workflows/pr.yaml
Lines 140 to 142 in 050d524
extra-repo: rapidsai/cugraph-ops | |
extra-repo-sha: branch-24.12 | |
extra-repo-deploy-key: CUGRAPH_OPS_SSH_PRIVATE_DEPLOY_KEY |
cugraph/.github/workflows/pr.yaml
Lines 159 to 161 in 050d524
extra-repo: rapidsai/cugraph-ops | |
extra-repo-sha: branch-24.12 | |
extra-repo-deploy-key: CUGRAPH_OPS_SSH_PRIVATE_DEPLOY_KEY |
cugraph/.github/workflows/test.yaml
Line 26 in 050d524
symbol_exclusions: (cugraph::ops|hornet|void writeEdgeCountsKernel|void markUniqueOffsetsKernel) |
build scripts (click me)
Line 46 in 050d524
--without_cugraphops |
Line 110 in 050d524
BUILD_WITH_CUGRAPHOPS=ON |
Line 271 in 050d524
-DUSE_CUGRAPH_OPS=${BUILD_WITH_CUGRAPHOPS} \ |
many more in build.sh
cugraph/ci/build_wheel_cugraph.sh
Line 31 in 050d524
export SKBUILD_CMAKE_ARGS="-DDETECT_CONDA_ENV=OFF;-DFIND_CUGRAPH_CPP=OFF;-DCPM_cugraph-ops_SOURCE=${GITHUB_WORKSPACE}/cugraph-ops/${EXTRA_CMAKE_ARGS}" |
cugraph/ci/build_wheel_pylibcugraph.sh
Line 18 in 050d524
export SKBUILD_CMAKE_ARGS="-DDETECT_CONDA_ENV=OFF;-DFIND_CUGRAPH_CPP=OFF;-DCPM_cugraph-ops_SOURCE=${GITHUB_WORKSPACE}/cugraph-ops/${EXTRA_CMAKE_ARGS}" |
dependency on 'libcugraphops' and 'pylibcugraphops' (click me)
Lines 23 to 24 in 050d524
# Deprecate pylibcugraphops | |
- depends_on_pylibcugraphops |
Lines 921 to 944 in 050d524
depends_on_pylibcugraphops: | |
common: | |
- output_types: conda | |
packages: | |
- &pylibcugraphops_unsuffixed pylibcugraphops==24.12.*,>=0.0.0a0 | |
- output_types: requirements | |
packages: | |
# pip recognizes the index as a global option for the requirements.txt file | |
- --extra-index-url=https://pypi.nvidia.com | |
- --extra-index-url=https://pypi.anaconda.org/rapidsai-wheels-nightly/simple | |
specific: | |
- output_types: [requirements, pyproject] | |
matrices: | |
- matrix: | |
cuda: "12.*" | |
cuda_suffixed: "true" | |
packages: | |
- pylibcugraphops-cu12==24.12.*,>=0.0.0a0 | |
- matrix: | |
cuda: "11.*" | |
cuda_suffixed: "true" | |
packages: | |
- pylibcugraphops-cu11==24.12.*,>=0.0.0a0 | |
- {matrix: null, packages: [*pylibcugraphops_unsuffixed]} |
Lines 429 to 430 in 050d524
# Deprecate libcugraphops | |
- libcugraphops==24.12.*,>=0.0.0a0 |
- libcugraphops ={{ minor_version }} |
and several more, see that git grep
output
@jameslamb Since CI has already passed here I am inclined to just accept this as-is and then iteratively rip out more. Maybe we can limit this PR's scope to CMake / C++ removal, and then do the removals you suggested (mostly CI, build scripts, dependencies, etc.) in a follow-up PR. I started to look into this as well and noticed there are quite a few references in the GNN code, which is being split out, so there may be potentially duplicate work that we should defer until after that split. |
Ok yeah fair enough, let's stop here and do more in follow-ups. |
@@ -186,11 +186,4 @@ def test_docstring(self, docstring): | |||
f"{docstring.name}:\n{doctest_stdout.getvalue()}" | |||
) | |||
except AssertionError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this is no longer using specialized logic in the exception clause, the "except: raise" pattern is unneeded. We can remove the try
entirely.
Delete deprecated cugraph-ops functionality, clean up references to cugraph-ops.