Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Sparse input support for tSNE #2751

Closed
JohnZed opened this issue Aug 24, 2020 · 0 comments · Fixed by #3293
Closed

[FEA] Sparse input support for tSNE #2751

JohnZed opened this issue Aug 24, 2020 · 0 comments · Fixed by #3293

Comments

@JohnZed
Copy link
Contributor

JohnZed commented Aug 24, 2020

Depends on sparse kNN
@divyegala divyegala mentioned this issue Dec 11, 2020
Merged
@rapids-bot rapids-bot bot closed this as completed in #3293 Jan 7, 2021
rapids-bot bot pushed a commit that referenced this issue Jan 7, 2021
@divyegala
Sparse TSNE(#3293)
4d2de05 
This PR allows TSNE to accept sparse inputs.

It also removes long-standing warnings ```ptxas warning : Value of threads per SM for entry _ZN2ML4TSNE17IntegrationKernelEfffPfS1_PKfS3_S3_S3_S1_S1_S1_S1_S3_i is out of range. .minnctapersm will be ignored
ptxas warning : Value of threads per SM for entry _ZN2ML4TSNE15RepulsionKernelEffPKiS2_PKfS4_S4_PfS5_S5_fiiiS4_S2_ is out of range. .minnctapersm will be ignored
ptxas warning : Value of threads per SM for entry _ZN2ML4TSNE18TreeBuildingKernelEPiPKfS3_iiS1_S1_S3_ is out of range. .minnctapersm will be ignored
ptxas warning : Value of threads per SM for entry _ZN2ML4TSNE17BoundingBoxKernelEPiS1_PfS2_S2_S2_S2_S2_S2_iiiPjS2_ is out of range. .minnctapersm will be ignored``` from cuml builds which were caused by invalid parameters to `__launch_bounds__` in TSNE kernels.

Furthermore, I also created a class `TSNE_runner` to handle running separate components of the algorithm as well as to ensure the proper use of RAII buffers and their de-allocation once their use is done, without explicitly deleting those buffers.

closes #2751

Authors:
  - divyegala <[email protected]>

Approvers:
  - Corey J. Nolet (@cjnolet)

URL: #3293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sparse TSNE divyegala/cuml
1 participant
@JohnZed