Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Move sparse prims to RAFT #3106

Closed
cjnolet opened this issue Oct 30, 2020 · 1 comment · Fixed by #3157
Closed

[FEA] Move sparse prims to RAFT #3106

cjnolet opened this issue Oct 30, 2020 · 1 comment · Fixed by #3157
Assignees
@cjnolet
Labels
0 - Blocked Cannot progress due to external reasons CUDA / C++ CUDA issue feature request New feature or request RAFT Issue or PR is related to RAFT Tech Debt Issues related to debt

Comments

@cjnolet
Copy link
Member

cjnolet commented Oct 30, 2020

This should also include breaking the prims into separate directories that (somewhat) mirror the non-sparse prims (e.g. linalg, stats, etc...).
@cjnolet cjnolet added feature request New feature or request CUDA / C++ CUDA issue Tech Debt Issues related to debt RAFT Issue or PR is related to RAFT labels Oct 30, 2020
@cjnolet
Copy link
Member Author

cjnolet commented Nov 6, 2020

Depends on #2836

@cjnolet cjnolet added the 0 - Blocked Cannot progress due to external reasons label Nov 6, 2020
This was referenced Nov 18, 2020
Closed
Merged
@cjnolet cjnolet self-assigned this Dec 14, 2020
rapids-bot bot pushed a commit that referenced this issue Jan 16, 2021
@cjnolet
Preparing sparse primitives for movement to RAFT(#3157)
d72c54a 
This PR contains the initial steps to move many of the sparse prims API over to raft, including:
- [x] Adjusting `MLCommon::Sparse` namespaces to `raft::sparse` 
- [x] Breaking csr/coo prims into multiple files (e.g. linalg, components, matrix, etc...)
- [x] Using RAFT namespaces for raft componentry used within the sparse prims, such as `device_buffer` and `deviceAllocator`. 
- [x] Use RAFT handle in public API
Closes #3106

Authors:
  - Corey J. Nolet <[email protected]>
  - Ray Douglass <[email protected]>

Approvers:
  - Divye Gala (@divyegala)
  - Divye Gala (@divyegala)
  - John Zedlewski (@JohnZed)

URL: #3157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjnolet cjnolet

Labels
0 - Blocked Cannot progress due to external reasons CUDA / C++ CUDA issue feature request New feature or request RAFT Issue or PR is related to RAFT Tech Debt Issues related to debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preparing sparse primitives for movement to RAFT cjnolet/cuml
1 participant
@cjnolet