Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add Dask test code coverage to codecov.io #3171

Closed
JohnZed opened this issue Nov 23, 2020 · 2 comments · Fixed by #3338
Closed

[FEA] Add Dask test code coverage to codecov.io #3171

JohnZed opened this issue Nov 23, 2020 · 2 comments · Fixed by #3338
Assignees
@mdemoret-nv

Comments

@JohnZed
Copy link
Contributor

JohnZed commented Nov 23, 2020

No description provided.

@mdemoret-nv mdemoret-nv mentioned this issue Jan 4, 2021
Merged
@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@mdemoret-nv
Copy link
Contributor

Work on this issue is still ongoing in the linked PR. Several Ops issues have slowed down development and prevented including this PR in 0.18. Merging shortly to branch-0.19

rapids-bot bot pushed a commit that referenced this issue Feb 18, 2021
@mdemoret-nv
Adding CodeCov Info for Dask Tests (#3338)
9845e26 
Closes #3171 

This PR adjusts the CI build script to generate code coverage output for the dask tests that are run separately from the rest of the cuML tests. Ideally, the `codecov` CLI will detect this additional output and automatically upload it. 

Still a WIP. Testing alternative upload methods for Codecov.io.

Authors:
  - Michael Demoret (@mdemoret-nv)
  - John Zedlewski (@JohnZed)

Approvers:
  - AJ Schmidt (@ajschmidt8)
  - Dillon Cullinan (@dillon-cullinan)
  - John Zedlewski (@JohnZed)

URL: #3338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdemoret-nv mdemoret-nv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Adding CodeCov Info for Dask Tests mdemoret-nv/cuml
2 participants
@JohnZed @mdemoret-nv