Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Gtest failure for Hellinger Distance #3477

Closed
cjnolet opened this issue Feb 9, 2021 · 0 comments · Fixed by #3549
Closed

[BUG] Gtest failure for Hellinger Distance #3477

cjnolet opened this issue Feb 9, 2021 · 0 comments · Fixed by #3549
Assignees
@cjnolet
Labels
bug Something isn't working CUDA / C++ CUDA issue tests Unit testing for project

Comments

@cjnolet
Copy link
Member

cjnolet commented Feb 9, 2021

This failure is still a little bit of a mystery. It fails in the same assertion when the whole test suite is executed. I found and fixed a couple very small thrust initialization problems but they only shifted the failed assertion to a different number.

I am unable to reproduce when running only that test case in isolation and compute-sanitize doesn’t show any problems. The PR in which this behavior was introduced was merged because CI didn’t fail, but that no longer seems to be the case.

Going to disable just this single test case (Hellinger) for 0.18 and investigate the fix so this can be re-enabled ASAP.
@cjnolet cjnolet added bug Something isn't working tests Unit testing for project CUDA / C++ CUDA issue labels Feb 9, 2021
@cjnolet cjnolet self-assigned this Feb 22, 2021
@cjnolet cjnolet mentioned this issue Feb 23, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Feb 24, 2021
@cjnolet
Fix failing Hellinger gtest (#3549)
6f06d4b 
Closes #3477

Authors:
  - Corey J. Nolet (@cjnolet)

Approvers:
  - Dante Gama Dessavre (@dantegd)

URL: #3549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjnolet cjnolet

Labels
bug Something isn't working CUDA / C++ CUDA issue tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Fix failing Hellinger gtest cjnolet/cuml
1 participant
@cjnolet