Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Calling a Scaler's fit_transform twice fails with a NoneType error #4034

Closed
esnvidia opened this issue Jul 7, 2021 · 2 comments
Closed

[BUG] Calling a Scaler's fit_transform twice fails with a NoneType error #4034

esnvidia opened this issue Jul 7, 2021 · 2 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@esnvidia
Copy link

esnvidia commented Jul 7, 2021

Describe the bug
Calling a Scaler's fit_transform twice fails with a NoneType Error. Possibly affects all Scalers (MinMaxScaler, StandardScaler, etc).

Steps/Code to reproduce bug

Code attached below.
image (1)
image (2)

Untitled.zip

For MinMaxScaler the error is: TypeError: Unsupported <class NoneType>

Expected behavior
Re-do the fit_transform and update the params (ex. mean, std for StandardScaler and max/min for MinMaxScaler)

Environment details (please complete the following information):
bare-metal, conda install rapids 21.06, ubuntu 20.04
@esnvidia esnvidia added ? - Needs Triage Need team to review and classify bug Something isn't working labels Jul 7, 2021
@esnvidia esnvidia mentioned this issue Jul 7, 2021
Closed
@dantegd
Copy link
Member

dantegd commented Jul 7, 2021

@viclafargue could you take a look at this when you have some bandwidth?

@viclafargue viclafargue mentioned this issue Jul 9, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 11, 2021
@viclafargue
Fix double fit crash in preprocessing models (#4040)
7613040 
Solves #4034

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4040
@dantegd
Copy link
Member

dantegd commented Jul 12, 2021

Fixed by #4040

@dantegd dantegd closed this as completed Jul 12, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this issue Oct 9, 2023
@viclafargue
Fix double fit crash in preprocessing models (rapidsai#4040)
3b2e71f 
Solves rapidsai#4034

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dantegd @esnvidia