Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo in SVC's predict_proba AttributeError when the model is not fit with probability=True [skip-ci] #3114

Merged
merged 3 commits into from
Nov 5, 2020

Conversation

tylerjthomas9
Copy link
Contributor

"with" at the end of the second line, and "probability" at the beginning of the third line did not have a space between them.

Current Error:
AttributeError: This classifier is not fitted to predict probabilities. Fit a new classifier withprobability=True to enable predict_proba.

New Error:
AttributeError: This classifier is not fitted to predict probabilities. Fit a new classifier with probability=True to enable predict_proba.

with at the end of the second line, and probability at the beginning of the third line did not have a space between them.
@tylerjthomas9 tylerjthomas9 requested a review from a team as a code owner November 4, 2020 15:39
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

2 similar comments
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@dantegd
Copy link
Member

dantegd commented Nov 4, 2020

@tylerjthomas9 thank you very much for the PR? Could we ask you to add a corresponding entry to the changelog? https://github.com/rapidsai/cuml/blob/branch-0.17/CHANGELOG.md Thanks!

@tylerjthomas9
Copy link
Contributor Author

@tylerjthomas9 thank you very much for the PR? Could we ask you to add a corresponding entry to the changelog? https://github.com/rapidsai/cuml/blob/branch-0.17/CHANGELOG.md Thanks!

Done!

@dantegd dantegd changed the title Fixed a typo in SVC's predict_proba AttributeError when the model is not fit with probability=True Fixed a typo in SVC's predict_proba AttributeError when the model is not fit with probability=True [skip-ci] Nov 4, 2020
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @tylerjthomas9 !

@JohnZed
Copy link
Contributor

JohnZed commented Nov 5, 2020

ok to test

@JohnZed JohnZed merged commit 1f563ee into rapidsai:branch-0.17 Nov 5, 2020
@tylerjthomas9 tylerjthomas9 deleted the patch-1 branch November 5, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants