Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Experimental versions of GPU accelerated Kernel and Permutation SHAP #3126

Merged
merged 55 commits into from
Dec 2, 2020
Merged

[REVIEW] Experimental versions of GPU accelerated Kernel and Permutation SHAP #3126

merged 55 commits into from
Dec 2, 2020

Commits on Nov 9, 2020

  1. FEA Separate kernel shap from shared shap branch for PR

    @dantegd
    dantegd committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    fe99177 View commit details
    Browse the repository at this point in the history

  2. FIX Typos

    @dantegd
    dantegd committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    52bfcd8 View commit details
    Browse the repository at this point in the history

  3. FIX Typos

    @dantegd
    dantegd committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    5021358 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. FEA Add files to cmakelists

    @dantegd
    dantegd committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    26f21e6 View commit details
    Browse the repository at this point in the history

  2. ENH small corrections and started incorporating PR review feedback

    @dantegd
    dantegd committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    ee47596 View commit details
    Browse the repository at this point in the history

  3. ENH progress on remaining todos

    @dantegd
    dantegd committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    2d51f8e View commit details
    Browse the repository at this point in the history

  4. [FIX] typo 

    Co-authored-by: John Zedlewski <[email protected]>
    @dantegd @JohnZed
    dantegd and JohnZed authored Nov 11, 2020
    Configuration menu
    Copy the full SHA
    e3aa3af View commit details
    Browse the repository at this point in the history

  5. FIX Small function typo

    @dantegd
    dantegd committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    14f0a8b View commit details
    Browse the repository at this point in the history

  6. Merge branch '017-fea-kshap' of github.com:dantegd/cuml into 017-fea-… 

    …kshap
    @dantegd
    dantegd committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    18cec88 View commit details
    Browse the repository at this point in the history

  7. ENH Multiple small enhancements and fixes

    @dantegd
    dantegd committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    dffb7b9 View commit details
    Browse the repository at this point in the history

  8. ENH Use tags for device model detection

    @dantegd
    dantegd committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    267468f View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. ENH data type changes

    @dantegd
    dantegd committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    90f59c5 View commit details
    Browse the repository at this point in the history

  2. ENH Add pytest files

    @dantegd
    dantegd committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    96baa48 View commit details
    Browse the repository at this point in the history

  3. ENH multiple enhancements, completed todos and fixes

    @dantegd
    dantegd committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    5602f28 View commit details
    Browse the repository at this point in the history

  4. ENH naming, comments and code enhancements to C++ code

    @dantegd
    dantegd committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    df5517f View commit details
    Browse the repository at this point in the history

  5. ENH clang-format cleanup

    @dantegd
    dantegd committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    ec8af23 View commit details
    Browse the repository at this point in the history

  6. ENH variable rename for clarity

    @dantegd
    dantegd committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    204dbcf View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. ENH Add explainer common pytests

    @dantegd
    dantegd committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    9189efa View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Merge branch 'branch-0.17' of https://github.com/rapidsai/cuml into 0… 

    …17-fea-kshap
    @dantegd
    dantegd committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    13bf8e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. ENH Use raft handle device properties

    @dantegd
    dantegd committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    0396424 View commit details
    Browse the repository at this point in the history

  2. ENH Many more enhancements, better weighter linear regression

    @dantegd
    dantegd committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    0e8e405 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. ENH Add googletest and c++ improvements from PR feedback

    @dantegd
    dantegd committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    5349e47 View commit details
    Browse the repository at this point in the history

  2. ENH clang-format and comments about the tests

    @dantegd
    dantegd committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    c5e09da View commit details
    Browse the repository at this point in the history

  3. FIX remove straggling prints

    @dantegd
    dantegd committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    76fc081 View commit details
    Browse the repository at this point in the history

  4. FIX Uncomment all other c++ tests

    @dantegd
    dantegd committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    bf32ddc View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. ENH Multiple small python enhancements and bugfixes

    @dantegd
    dantegd committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    d876f44 View commit details
    Browse the repository at this point in the history

  2. ENH More python small improvements, rename class to match mainline

    @dantegd
    dantegd committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    aceddec View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. ENH Big python code cleanup and incorporating PR feedback. New SHAPBa… 

    …se class
    @dantegd
    dantegd committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    2dd1fa1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-0.17' of https://github.com/rapidsai/cuml into 0… 

    …17-fea-kshap
    @dantegd
    dantegd committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    347c51b View commit details
    Browse the repository at this point in the history

  3. ENH Incorporate rest of feedback of KernelSHAP and Base

    @dantegd
    dantegd committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    64c60e9 View commit details
    Browse the repository at this point in the history

  4. ENH Add full coverage to explainer common tests

    @dantegd
    dantegd committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    d7516da View commit details
    Browse the repository at this point in the history

  5. ENH Small numeric and other enhancements

    @dantegd
    dantegd committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    b2ddd21 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2020

  1. ENH Multiple enhancements including coalesced kernel, generating samp… 

    …les by compliments, googletest changes to account for that
    @dantegd
    dantegd committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    67d8025 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. FIX clang format fixes

    @dantegd
    dantegd committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    aae8dee View commit details
    Browse the repository at this point in the history

  2. FEA Improvements to pytests

    @dantegd
    dantegd committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    9af98d8 View commit details
    Browse the repository at this point in the history

  3. ENH More python enhancements and simplify perm SHAP to use SHAPBase c… 

    …lass
    @dantegd
    dantegd committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    6ab7326 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-0.17' of https://github.com/rapidsai/cuml into 0… 

    …17-fea-kshap
    @dantegd
    dantegd committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    8d6d105 View commit details
    Browse the repository at this point in the history

  5. DOC Added entry to changelog

    @dantegd
    dantegd committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    a21f20a View commit details
    Browse the repository at this point in the history

  6. ENH Various small style fixes, doc fixes, tidying up straggling comments

    @dantegd
    dantegd committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    5679e3d View commit details
    Browse the repository at this point in the history

  7. FIX PEP8 fixes

    @dantegd
    dantegd committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    2170217 View commit details
    Browse the repository at this point in the history

  8. FIX test margins that I had forgotten to adjust, some might still be … 

    …tighter than needed
    @dantegd
    dantegd committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    0566dfc View commit details
    Browse the repository at this point in the history

  9. FIX add missing stream sync to test and print in case of failure

    @dantegd
    dantegd committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    81a95ee View commit details
    Browse the repository at this point in the history

  10. FIX always run clang-format I keep telling myself...

    @dantegd
    dantegd committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    d132522 View commit details
    Browse the repository at this point in the history

  11. FIX Small type correction that seems to be the root of the googletest… 

    … fail only on cuda 10.1
    @dantegd
    dantegd committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    ecdee14 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. FIX temporarily disable specific googletest for 0.17 burndown

    @dantegd
    dantegd committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    fe2dc74 View commit details
    Browse the repository at this point in the history

  2. FIX Had disabled the test in the incorrect place :(

    @dantegd
    dantegd committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    9013548 View commit details
    Browse the repository at this point in the history

  3. FIX remove straggling prints

    @dantegd
    dantegd committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    5886407 View commit details
    Browse the repository at this point in the history

  4. Update cpp/src/explainer/kernel_shap.cu 

    Co-authored-by: John Zedlewski <[email protected]>
    @dantegd @JohnZed
    dantegd and JohnZed authored Dec 1, 2020
    Configuration menu
    Copy the full SHA
    30242e6 View commit details
    Browse the repository at this point in the history

  5. Update python/cuml/common/import_utils.py 

    Co-authored-by: John Zedlewski <[email protected]>
    @dantegd @JohnZed
    dantegd and JohnZed authored Dec 1, 2020
    Configuration menu
    Copy the full SHA
    6cfe98e View commit details
    Browse the repository at this point in the history

  6. Update python/cuml/experimental/explainer/base.py 

    Co-authored-by: John Zedlewski <[email protected]>
    @dantegd @JohnZed
    dantegd and JohnZed authored Dec 1, 2020
    Configuration menu
    Copy the full SHA
    2cd7d0e View commit details
    Browse the repository at this point in the history

  7. ENH incorporating PR review feedback

    @dantegd
    dantegd committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    7c50130 View commit details
    Browse the repository at this point in the history

  8. FIX solve changelog conflict

    @dantegd
    dantegd committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    d6ebad4 View commit details
    Browse the repository at this point in the history

  9. FIX clang format fixes

    @dantegd
    dantegd committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    2e0374f View commit details
    Browse the repository at this point in the history

  10. FIX reduce test size and case matrix of test that was slow in CI

    @dantegd
    dantegd committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    3725127 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. FIX c++ docstring fix

    @dantegd
    dantegd committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    454180d View commit details
    Browse the repository at this point in the history