Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Python string from dump_as_json() of RF #3130

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Nov 10, 2020

The C++ string return value from dump_rf_as_json() is read as bytes in the Python layer. Add decode('utf-8') to obtain a Python string instead.

@hcho3 hcho3 requested a review from a team as a code owner November 10, 2020 21:15
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@hcho3 hcho3 added the 3 - Ready for Review Ready for review by team label Nov 10, 2020
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change lgtm

@dantegd dantegd added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #3130 (f34b64b) into branch-0.17 (25b29f5) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.17    #3130   +/-   ##
============================================
  Coverage        69.38%   69.38%           
============================================
  Files              193      193           
  Lines            14704    14704           
============================================
  Hits             10203    10203           
  Misses            4501     4501           
Impacted Files Coverage Δ
python/cuml/ensemble/randomforestclassifier.pyx 72.72% <50.00%> (ø)
python/cuml/ensemble/randomforestregressor.pyx 70.08% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b29f5...f34b64b. Read the comment docs.

@dantegd dantegd merged commit d9a73a7 into rapidsai:branch-0.17 Nov 11, 2020
@hcho3 hcho3 deleted the use_pystr_rf_dump branch November 25, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants