[REVIEW] Move DistanceType enum to RAFT #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
|
Replacement for #2918 |
|
@divyegala Would you mind taking a look at this when you get a chance? |
dantegd
approved these changes
Nov 13, 2020
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3141 +/- ##
============================================
Coverage 70.57% 70.57%
============================================
Files 197 197
Lines 15461 15461
============================================
Hits 10911 10911
Misses 4550 4550
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all references from the DistanceType enum defined in cuML to the equivalent defined in RAFT. This change facilitates future re-use of this enum across Cython and prims code.