[REVIEW] Adding Ability to Set Arbitrary Cmake Flags in ./build.sh [skip-ci] #3144
Conversation
…ML_ADDL_CMAKE_ARGS variable
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
|
@JohnZed Is this all you were looking for to close the linked issue? Or did you need something more? |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3144 +/- ##
===============================================
- Coverage 70.57% 70.57% -0.01%
===============================================
Files 197 197
Lines 15465 15465
===============================================
- Hits 10915 10914 -1
- Misses 4550 4551 +1
Continue to review full report at Codecov.
|
build.sh
Outdated
| @@ -74,6 +74,12 @@ BUILD_STATIC_FAISS=OFF | |||
| INSTALL_PREFIX=${INSTALL_PREFIX:=${PREFIX:=${CONDA_PREFIX}}} | |||
| PARALLEL_LEVEL=${PARALLEL_LEVEL:=""} | |||
|
|
|||
| # Allow setting arbitrary cmake args via the $CUML_ADDL_CMAKE_ARGS variable. Any | |||
| # values listed here will override existing arguments. For example: | |||
| # CUML_ADDL_CMAKE_ARGS="-DBUILD_CUML_C_LIBRARY=OFF" ./build.sh | |||
There was a problem hiding this comment.
really picky thought but could we make it CUML_EXTRA_CMAKE_ARGS instead? like how in Make you have "EXTRA_CFLAGS" insteasd of ADDL_CFLAGS?
There was a problem hiding this comment.
I renamed it to CUML_EXTRA_CMAKE_ARGS as requested. There was also a similar variable for python build that I renamed to CUML_EXTRA_PYTHON_ARGS to match. See the help output for an example:
The following environment variables are also accepted to allow further customization:
PARALLEL_LEVEL - Number of parallel threads to use in compilation.
CUML_EXTRA_CMAKE_ARGS - Extra arguments to pass directly to cmake. Values listed in environment
variable will override existing arguments. Example:
CUML_EXTRA_CMAKE_ARGS="-DBUILD_CUML_C_LIBRARY=OFF" ./build.sh
CUML_EXTRA_PYTHON_ARGS - Extra argument to pass directly to python setup.py
mdemoret-nv
added
the
4 - Waiting on Reviewer
mdemoret-nv
added
5 - Ready to Merge
JohnZed
changed the title
Closes #3127
This PR simply adds the environment variable
$CUML_ADDL_CMAKE_ARGSto./build.shto allow developers to set arbitrary cmake flags on the command line. Below is a simple example:CUML_ADDL_CMAKE_ARGS="-DBUILD_CUML_C_LIBRARY=OFF" ./build.shThis would disable building the cuML C library which is hard coded to
ONin./build.sh.Note: If cmake options are specified multiple times on the command line, the latter will override the former allowing this variable to work for options that are already specified in
./build.sh