Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Get rid of warnings in random projection test and related deprecation warnings #3155

Merged
merged 4 commits into from
Nov 19, 2020
Merged

[REVIEW] Get rid of warnings in random projection test and related deprecation warnings #3155

merged 4 commits into from
Nov 19, 2020

Conversation

JohnZed
Copy link
Contributor

@JohnZed JohnZed commented Nov 18, 2020 •
edited
Loading

This eliminates a very large number of sklearn warnings and means we will work reliably with newer sklearn versions post-0.25.

@JohnZed JohnZed requested a review from a team as a code owner November 18, 2020 18:47
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@JohnZed JohnZed requested a review from a team as a code owner November 18, 2020 19:45
@JohnZed JohnZed changed the title [REVIEW] Get rid of warnings in random projection test [REVIEW] Get rid of warnings in random projection test and related deprecation warnings Nov 18, 2020
@JohnZed
Copy link
Contributor Author

JohnZed commented Nov 18, 2020

Ended up removing a bunch of similar deprecation warnings.

@JohnZed JohnZed added the 3 - Ready for Review Ready for review by team label Nov 18, 2020
@codecov-io
Copy link

codecov-io commented Nov 18, 2020 •
edited
Loading

Codecov Report

Merging #3155 (63a8d7f) into branch-0.17 (d8b4765) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.17    #3155   +/-   ##
============================================
  Coverage        70.50%   70.50%           
============================================
  Files              196      196           
  Lines            15442    15442           
============================================
  Hits             10887    10887           
  Misses            4555     4555
Impacted Files Coverage Δ
...ython/cuml/random_projection/random_projection.pyx 83.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b4765...63a8d7f. Read the comment docs.

Nanthini10
Nanthini10 approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@Nanthini10 Nanthini10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Nanthini10 Nanthini10 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 18, 2020
dantegd
dantegd approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeowners approval

@cjnolet cjnolet merged commit bb006a4 into rapidsai:branch-0.17 Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nanthini10 Nanthini10 Nanthini10 approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JohnZed @GPUtester @codecov-io @dantegd @Nanthini10 @cjnolet