-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Expose silhouette score in Python #3164
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3164 +/- ##
===============================================
+ Coverage 70.90% 70.98% +0.07%
===============================================
Files 197 198 +1
Lines 15682 15725 +43
===============================================
+ Hits 11120 11162 +42
- Misses 4562 4563 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far, just have some comments and questions
Add Cython bindings for silhouette_score
Add Python functions corresponding to sklearn's silhouette_samples and silhouette_score
Update metric selection to make use of DistanceType enum
Resolve #645
Resolve #796