Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Expose silhouette score in Python #3164

Merged
merged 12 commits into from
Nov 24, 2020

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Nov 20, 2020

Add Cython bindings for silhouette_score
Add Python functions corresponding to sklearn's silhouette_samples and silhouette_score
Update metric selection to make use of DistanceType enum

Resolve #645
Resolve #796

@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@wphicks wphicks changed the title [WIP] Expose silhouette score in Python [WIP] Expose silhouette score in Python [skip-ci] Nov 20, 2020
@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #3164 (d8d17b0) into branch-0.17 (2a84c52) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3164      +/-   ##
===============================================
+ Coverage        70.90%   70.98%   +0.07%     
===============================================
  Files              197      198       +1     
  Lines            15682    15725      +43     
===============================================
+ Hits             11120    11162      +42     
- Misses            4562     4563       +1     
Impacted Files Coverage Δ
python/cuml/metrics/pairwise_distances.pyx 98.83% <ø> (ø)
python/cuml/metrics/cluster/__init__.py 100.00% <100.00%> (ø)
python/cuml/metrics/cluster/silhouette_score.pyx 100.00% <100.00%> (ø)
...l/_thirdparty/sklearn/preprocessing/_imputation.py 62.09% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a84c52...d8d17b0. Read the comment docs.

@wphicks wphicks changed the title [WIP] Expose silhouette score in Python [skip-ci] [WIP] Expose silhouette score in Python Nov 21, 2020
@wphicks wphicks changed the title [WIP] Expose silhouette score in Python [REVIEW] Expose silhouette score in Python Nov 21, 2020
@wphicks wphicks marked this pull request as ready for review November 21, 2020 00:27
@wphicks wphicks requested review from a team as code owners November 21, 2020 00:27
@wphicks wphicks added the 3 - Ready for Review Ready for review by team label Nov 21, 2020
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far, just have some comments and questions

python/cuml/metrics/cluster/__init__.py Outdated Show resolved Hide resolved
python/cuml/metrics/cluster/silhouette_score.py Outdated Show resolved Hide resolved
python/cuml/metrics/cluster/silhouette_score.py Outdated Show resolved Hide resolved
python/cuml/metrics/cluster/silhouette_score.py Outdated Show resolved Hide resolved
python/cuml/metrics/cluster/silhouette_score.py Outdated Show resolved Hide resolved
python/cuml/metrics/cluster/silhouette_score_impl.pyx Outdated Show resolved Hide resolved
python/cuml/metrics/cluster/silhouette_score_impl.pyx Outdated Show resolved Hide resolved
@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review Cython / Python Cython or Python issue and removed 3 - Ready for Review Ready for review by team labels Nov 21, 2020
@wphicks wphicks added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels Nov 23, 2020
@dantegd dantegd merged commit 45aa019 into rapidsai:branch-0.17 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond Cython / Python Cython or Python issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Cython wrapper for silhouette score [FEA] Silhouette score - expose C++ layer to python
4 participants