[REVIEW] Fix Attribute error on IPCA #3183 and PCA input type #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3190 +/- ##
===============================================
+ Coverage 70.99% 71.02% +0.02%
===============================================
Files 198 198
Lines 15729 15731 +2
===============================================
+ Hits 11167 11173 +6
+ Misses 4562 4558 -4
Continue to review full report at Codecov.
|
lowener
changed the title
cjnolet
added
3 - Ready for Review
divyegala
approved these changes
Nov 30, 2020
JohnZed
approved these changes
Nov 30, 2020
|
|
||
| if return_sparse: | ||
| pytest.skip("Loss of information in converting to cupy sparse csr") | ||
|
|
||
| X = cupyx.scipy.sparse.random(nrows, ncols, density=0.07, dtype=cp.float32, | ||
| random_state=10) | ||
| if not(cupy_input): |
There was a problem hiding this comment.
for future reference - you don't need these parentheses
JohnZed
changed the title
JohnZed
changed the title
JohnZed
added
6 - Okay to Auto-Merge
bug
lowener
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing the attribute error of #3183, and additional bugs on the input type of PCA (
sparse_scipy_to_cp()function call missed an argument) and on the shape ofself.singular_values_.I am also adding additional tests on the bug fixed here.