Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Enable pipeline usage for OneHotEncoder and LabelEncoder #3192

Merged

Conversation

viclafargue
Copy link
Contributor

Answers #3053

@viclafargue viclafargue requested a review from a team as a code owner November 25, 2020 18:01
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@viclafargue
Copy link
Contributor Author

rerun tests

@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #3192 (7df31b9) into branch-0.17 (f1abcb8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3192      +/-   ##
===============================================
+ Coverage        70.99%   71.00%   +0.01%     
===============================================
  Files              198      198              
  Lines            15729    15729              
===============================================
+ Hits             11167    11169       +2     
+ Misses            4562     4560       -2     
Impacted Files Coverage Δ
python/cuml/preprocessing/LabelEncoder.py 92.98% <100.00%> (ø)
python/cuml/preprocessing/encoders.py 95.10% <100.00%> (ø)
...hirdparty/sklearn/preprocessing/_discretization.py 85.60% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1abcb8...7df31b9. Read the comment docs.

Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet cjnolet merged commit 1369aad into rapidsai:branch-0.17 Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants