Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Added a missing __syncthreads() #3215

Merged
merged 4 commits into from
Dec 1, 2020
Merged

[REVIEW] Added a missing __syncthreads() #3215

merged 4 commits into from
Dec 1, 2020

Conversation

canonizer
Copy link
Contributor

Added a missing __syncthreads().

@canonizer
Added a missing __syncthreads().
08cbda6 
- also re-enabled Sparse16 FIL tests
@canonizer canonizer requested a review from a team as a code owner December 1, 2020 01:11
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@canonizer canonizer changed the title Added a missing __syncthreads() [REVIEW] Added a missing __syncthreads() Dec 1, 2020
teju85
teju85 approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@teju85 teju85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teju85 teju85 added non-breaking Non-breaking change bug Something isn't working labels Dec 1, 2020
@codecov-io
Copy link

codecov-io commented Dec 1, 2020 •
edited
Loading

Codecov Report

Merging #3215 (d1efdd6) into branch-0.17 (13600f7) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3215      +/-   ##
===============================================
+ Coverage        71.00%   71.12%   +0.12%     
===============================================
  Files              198      198              
  Lines            15750    15841      +91     
===============================================
+ Hits             11183    11267      +84     
- Misses            4567     4574       +7
Impacted Files Coverage Δ
python/cuml/naive_bayes/naive_bayes.py 92.27% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13600f7...d1efdd6. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 5697e09 into rapidsai:branch-0.17 Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levsnv levsnv levsnv approved these changes

@teju85 teju85 teju85 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [TEST] Flaky test failures in FilTests/PredictSparse16FilTest.Predict
7 participants
@canonizer @GPUtester @codecov-io @teju85 @levsnv @JohnZed @dantegd