Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Specify branches to avoid pip resolver issue #3218

Merged

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Dec 1, 2020

Avoid dependency resolution failure in latest version of pip by explicitly specifying versions for dask and distributed

Resolve #3210

@wphicks wphicks requested a review from a team as a code owner December 1, 2020 17:34
@wphicks wphicks added bug Something isn't working non-breaking Non-breaking change labels Dec 1, 2020
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@jakirkham
Copy link
Member

Would grab these 2 as well

cuml/ci/gpu/build.sh

Lines 73 to 74 in 4a0e67a

pip install "git+https://github.com/dask/distributed.git" --upgrade --no-deps
pip install "git+https://github.com/dask/dask.git" --upgrade --no-deps

@wphicks wphicks added the 3 - Ready for Review Ready for review by team label Dec 1, 2020
@wphicks wphicks changed the title Specify branches to avoid pip resolver issue [REVIEW] Specify branches to avoid pip resolver issue Dec 1, 2020
@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #3218 (b89a9ef) into branch-0.17 (13600f7) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3218      +/-   ##
===============================================
- Coverage        71.00%   70.99%   -0.01%     
===============================================
  Files              198      198              
  Lines            15750    15729      -21     
===============================================
- Hits             11183    11167      -16     
+ Misses            4567     4562       -5     
Impacted Files Coverage Δ
python/cuml/decomposition/pca.pyx 92.19% <0.00%> (-1.52%) ⬇️
python/cuml/common/input_utils.py 92.53% <0.00%> (-0.77%) ⬇️
...cuml/experimental/decomposition/incremental_pca.py 86.66% <0.00%> (-0.09%) ⬇️
python/cuml/thirdparty_adapters/adapters.py 88.55% <0.00%> (ø)
.../dask/feature_extraction/text/tfidf_transformer.py 43.54% <0.00%> (ø)
...ython/cuml/dask/neighbors/kneighbors_classifier.py 22.00% <0.00%> (+0.70%) ⬆️
python/cuml/dask/neighbors/kneighbors_regressor.py 31.25% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13600f7...74de07f. Read the comment docs.

@JohnZed JohnZed added 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team labels Dec 2, 2020
@rapids-bot rapids-bot bot merged commit 4ae84f4 into rapidsai:branch-0.17 Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cuml_dev environment files result in ResolutionImpossible error during install
7 participants