Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Return confusion matrix as int unless float weights are used #3275

Merged
merged 3 commits into from
Dec 17, 2020
Merged

[REVIEW] Return confusion matrix as int unless float weights are used #3275

merged 3 commits into from
Dec 17, 2020

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Dec 8, 2020

This PR aims at converting the confusion matrix to int when possible, to avoid the scientific notation when possible.

See this example:

image

@lowener lowener requested a review from a team as a code owner December 8, 2020 00:57
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@lowener lowener changed the title [WIP] Adding the appropriate dtype for confusion matrix [REVIEW] Adding the appropriate dtype for confusion matrix Dec 8, 2020
@JohnZed JohnZed changed the title [REVIEW] Adding the appropriate dtype for confusion matrix [REVIEW] Return confusion matrix as int unless float weights are used Dec 11, 2020
@JohnZed
Copy link
Contributor

JohnZed commented Dec 11, 2020

Very nice! Technically an API- breaking change since the return type is changed, but definitely worth doing.

@JohnZed
Copy link
Contributor

JohnZed commented Dec 15, 2020

rerun tests

@JohnZed JohnZed added the improvement Improvement / enhancement to an existing function label Dec 15, 2020
@JohnZed
Copy link
Contributor

JohnZed commented Dec 17, 2020

rerun tests

@codecov-io
Copy link

codecov-io commented Dec 17, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.18@54ea23c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.18    #3275   +/-   ##
==============================================
  Coverage               ?   71.69%           
==============================================
  Files                  ?      207           
  Lines                  ?    16886           
  Branches               ?        0           
==============================================
  Hits                   ?    12107           
  Misses                 ?     4779           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ea23c...3c84172. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Dec 17, 2020

rerun tests

@rapids-bot rapids-bot bot merged commit 756061e into rapidsai:branch-0.18 Dec 17, 2020
@lowener lowener deleted the 018-add-confusion-matrix-type branch January 10, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnZed JohnZed JohnZed approved these changes

Assignees
No one assigned
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lowener @GPUtester @JohnZed @codecov-io @dantegd