[REVIEW] Fixing make_blobs to Respect the Global Output Type
#3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #3339 +/- ##
============================================
Coverage 71.48% 71.49%
============================================
Files 207 207
Lines 16750 16751 +1
============================================
+ Hits 11974 11976 +2
+ Misses 4776 4775 -1
Continue to review full report at Codecov.
|
JohnZed
approved these changes
Jan 5, 2021
mdemoret-nv
added
5 - Ready to Merge
JohnZed
added
6 - Okay to Auto-Merge
and removed
5 - Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3334
This was missed in the large CumlDescriptor and Decorators update. Changing the decorator to correctly respect the output type and adding a test to check the functionality.