Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Update failing MNMG tests #3348

Merged
merged 8 commits into from
Feb 8, 2021
Merged

[REVIEW] Update failing MNMG tests #3348

merged 8 commits into from
Feb 8, 2021

Conversation

viclafargue
Copy link
Contributor

@viclafargue viclafargue commented Jan 6, 2021 •
edited
Loading

Partially answers #3354.
The PR updates some of the failing MNMG tests so that nightly testing finally pass. This PR addresses MNMG RF and MNMG KNN tests failures.

@viclafargue viclafargue requested a review from a team as a code owner January 6, 2021 14:28
@viclafargue viclafargue added breaking Breaking change improvement Improvement / enhancement to an existing function labels Jan 6, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 14, 2021
@viclafargue viclafargue added bug Something isn't working 3 - Ready for Review Ready for review by team and removed Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function labels Jan 14, 2021
@viclafargue viclafargue changed the title [WIP] Update failing MNMG tests [REVIEW] Update failing MNMG tests Jan 14, 2021
JohnZed
JohnZed requested changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just check out that test size noted below

python/cuml/test/dask/test_random_forest.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 19, 2021
@viclafargue viclafargue added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 3 - Ready for Review Ready for review by team labels Jan 27, 2021
@JohnZed JohnZed added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Waiting on Reviewer Waiting for reviewer to review or respond labels Feb 3, 2021
@JohnZed
Copy link
Contributor

JohnZed commented Feb 8, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c1a7447 into rapidsai:branch-0.18 Feb 8, 2021
@viclafargue viclafargue mentioned this pull request Feb 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnZed JohnZed JohnZed approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change bug Something isn't working Cython / Python Cython or Python issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viclafargue @JohnZed