-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] genetic programming initial structures #3387
Merged
rapids-bot
merged 7 commits into
rapidsai:branch-0.18
from
teju85:fea-ext-genetic-programming-initial-structures
Feb 3, 2021
Merged
[REVIEW] genetic programming initial structures #3387
rapids-bot
merged 7 commits into
rapidsai:branch-0.18
from
teju85:fea-ext-genetic-programming-initial-structures
Feb 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teju85
added
non-breaking
Non-breaking change
CUDA / C++
CUDA issue
New Algorithm
For tracking new algorithms that will be added to our existing collection
3 - Ready for Review
Ready for review by team
and removed
CMake
libcuml
labels
Jan 20, 2021
…ea-ext-genetic-programming-initial-structures
rerun tests |
cjnolet
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending successful CI
@teju85, this looks like it needs copyrights updated. Otherwise, I think it's ready to go. |
Thanks @cjnolet I have fixed the copyright errors. |
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
CMake
CUDA / C++
CUDA issue
feature request
New feature or request
libcuml
New Algorithm
For tracking new algorithms that will be added to our existing collection
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces/proposes some of the basic and core (gpu-friendly!) data structures for implementing gplearn in cuML in order to address the issue #2121 .
Tagging all who will be involved in this development: @vinaydes @venkywonka @vimarsh6739.
PS: It also contains an experimental register-based stack implementation that will be useful while implementing CUDA-based AST evaluation, which is needed for organizing tournaments.