Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also xfail zlib errors when downloading newsgroups data #3393

Merged
merged 3 commits into from
Jan 22, 2021

Conversation

JohnZed
Copy link
Contributor

@JohnZed JohnZed commented Jan 20, 2021

Download errors can manifest as zlib.error as well as IOException it turns out (just saw this in CI)

@JohnZed JohnZed added bug Something isn't working tests Unit testing for project non-breaking Non-breaking change labels Jan 20, 2021
@JohnZed JohnZed requested a review from lowener January 20, 2021 23:19
@JohnZed JohnZed requested a review from a team as a code owner January 20, 2021 23:19
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 20, 2021
@JohnZed
Copy link
Contributor Author

JohnZed commented Jan 21, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Jan 21, 2021

@gpucibot merge

@codecov-io
Copy link

Codecov Report

Merging #3393 (01a5ed5) into branch-0.18 (550121b) will increase coverage by 0.14%.
The diff coverage is 85.77%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #3393      +/-   ##
===============================================
+ Coverage        71.48%   71.63%   +0.14%     
===============================================
  Files              207      210       +3     
  Lines            16748    16924     +176     
===============================================
+ Hits             11973    12123     +150     
- Misses            4775     4801      +26     
Impacted Files Coverage Δ
python/cuml/decomposition/incremental_pca.py 94.70% <ø> (ø)
python/cuml/dask/ensemble/base.py 19.69% <30.43%> (+0.36%) ⬆️
python/cuml/ensemble/randomforestregressor.pyx 70.83% <44.44%> (ø)
...ython/cuml/dask/ensemble/randomforestclassifier.py 30.00% <50.00%> (+0.51%) ⬆️
python/cuml/dask/ensemble/randomforestregressor.py 35.08% <50.00%> (+0.54%) ⬆️
python/cuml/fil/fil.pyx 91.87% <60.00%> (-1.88%) ⬇️
python/cuml/ensemble/randomforestclassifier.pyx 73.72% <66.66%> (ø)
python/cuml/multiclass/multiclass.py 84.21% <84.21%> (ø)
python/cuml/model_selection/_split.py 90.35% <90.35%> (ø)
python/cuml/svm/svm_base.pyx 94.27% <91.30%> (-0.63%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816bb65...01a5ed5. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 29f7d08 into rapidsai:branch-0.18 Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants