-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Parallelize Treelite to FIL conversion over trees #3396
[REVIEW] Parallelize Treelite to FIL conversion over trees #3396
Conversation
Revert to using vector to store nodes after extensive testing demonstrated that performance impact was negligible and due only to useful error checking
Note that @canonizer previously proposed replacing |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #3396 +/- ##
===============================================
+ Coverage 71.48% 71.63% +0.14%
===============================================
Files 207 210 +3
Lines 16748 16924 +176
===============================================
+ Hits 11973 12123 +150
- Misses 4775 4801 +26
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small technical comments, otherwise looks good.
Co-authored-by: Andy Adinets <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved again.
@gpucibot merge |
Convert Treelite trees to FIL in parallel
Improve speed of initial prediction for a model with 300 trees of approximately 4M nodes by an average of 5.9% on a system with 12 Intel Xeon Gold 6128 CPUs available