Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix vectorizer tests by restoring sort behavior in groupby #3416

Merged

Conversation

JohnZed
Copy link
Contributor

@JohnZed JohnZed commented Jan 27, 2021

cuDF group by now no longer performs a sort by default. This change just restores the old behavior in vectorizers by applying a sort to everything.

@JohnZed JohnZed added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jan 27, 2021
@JohnZed JohnZed requested a review from a team as a code owner January 27, 2021 04:23
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 27, 2021
@codecov-io
Copy link

Codecov Report

Merging #3416 (41bcad0) into branch-0.18 (550121b) will increase coverage by 0.17%.
The diff coverage is 85.19%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #3416      +/-   ##
===============================================
+ Coverage        71.48%   71.66%   +0.17%     
===============================================
  Files              207      210       +3     
  Lines            16748    16945     +197     
===============================================
+ Hits             11973    12144     +171     
- Misses            4775     4801      +26     
Impacted Files Coverage Δ
python/cuml/decomposition/incremental_pca.py 94.70% <ø> (ø)
python/cuml/dask/ensemble/base.py 19.69% <30.43%> (+0.36%) ⬆️
python/cuml/dask/cluster/kmeans.py 54.00% <33.33%> (ø)
python/cuml/ensemble/randomforestregressor.pyx 70.83% <44.44%> (ø)
python/cuml/dask/decomposition/base.py 39.53% <50.00%> (ø)
...ython/cuml/dask/ensemble/randomforestclassifier.py 30.00% <50.00%> (+0.51%) ⬆️
python/cuml/dask/ensemble/randomforestregressor.py 35.08% <50.00%> (+0.54%) ⬆️
python/cuml/dask/linear_model/linear_regression.py 59.09% <50.00%> (ø)
python/cuml/dask/linear_model/ridge.py 50.00% <50.00%> (ø)
...ython/cuml/dask/neighbors/kneighbors_classifier.py 22.33% <50.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff478f...41bcad0. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Jan 27, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c403f83 into rapidsai:branch-0.18 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants