Adding tol to dask test_kmeans #3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
added
bug
dantegd
requested changes
Jan 29, 2021
| @@ -193,4 +193,4 @@ def test_score(nrows, ncols, nclusters, n_parts, | |||
| local_model = cumlModel.get_combined_model() | |||
| expected_score = local_model.score(X_train.compute()) | |||
|
|
|||
| assert actual_score == expected_score | |||
| assert abs(actual_score - expected_score) < 1e-3 | |||
There was a problem hiding this comment.
Why was 1e-3 in particular chosen?
There was a problem hiding this comment.
Because it's small enough compared to the numbers in the assertion (15k and 5k).
The error reported in the issue were in the order of 2e-4.
JohnZed
approved these changes
Jan 30, 2021
|
@gpucibot merge |
dantegd
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2969.
This PR add tolerance to dask test_kmeans in order to be flexible with small accumulation mistakes in a distributed context.