Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve QN solver stopping conditions (logistic regression) to match sklearn closer #3766

Merged
merged 7 commits into from
Apr 23, 2021
Merged

Improve QN solver stopping conditions (logistic regression) to match sklearn closer #3766

merged 7 commits into from
Apr 23, 2021

Commits on Apr 15, 2021

  1. Change the stopping condition to L-inf scaled with |fx|

    @achirkin
    achirkin committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    99dd8f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Change the default tolerance to match sklearn and linear_regression.pyx

    @achirkin
    achirkin committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    3dca6ca View commit details
    Browse the repository at this point in the history

  2. Modify the secondary stop condition to have the same logic.

    @achirkin
    achirkin committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    69eae38 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Fix a docstring.

    @achirkin
    achirkin committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    37e39a7 View commit details
    Browse the repository at this point in the history

  2. Fix the copyright year

    @achirkin
    achirkin committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    fb3dea0 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Note the difference to sklearn

    @achirkin
    achirkin committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    d9c86fe View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Update documentation

    @achirkin
    achirkin committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    bd96fda View commit details
    Browse the repository at this point in the history