Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate QN linesearch failures when it's harmless #3791

Merged
merged 8 commits into from
Jul 22, 2021
Merged

Tolerate QN linesearch failures when it's harmless #3791

merged 8 commits into from
Jul 22, 2021

Commits on Apr 27, 2021

  1. Tolerate linesearch failures sometimes

    @achirkin
    achirkin committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    01db379 View commit details
    Browse the repository at this point in the history

  2. Fix a typo and print the LS return code

    @achirkin
    achirkin committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    687eb35 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Merge branch 'branch-21.08' into bug-ext-qn-linesearch-failure

    @achirkin
    achirkin committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    5104be0 View commit details
    Browse the repository at this point in the history

  2. Make linesearch complain only if not converged.

    @achirkin
    achirkin committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    d2055c7 View commit details
    Browse the repository at this point in the history

  3. Stop due to linesearch doing nothing.

    @achirkin
    achirkin committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    63cca81 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Add more comments and bring back some trace messages

    @achirkin
    achirkin committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    5ce7796 View commit details
    Browse the repository at this point in the history

  2. Update cpp/src/glm/qn/qn_solvers.cuh 

    Co-authored-by: Tamas Bela Feher <[email protected]>
    @achirkin @tfeher
    achirkin and tfeher authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    18ced01 View commit details
    Browse the repository at this point in the history

  3. Make the debug messages less worrying for the users

    @achirkin
    achirkin committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    c9aaab2 View commit details
    Browse the repository at this point in the history