Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable UMAP deterministic test on CTK11.2 #3942

Merged

Conversation

trivialfis
Copy link
Member

This reverts part of 99a80c8 due to unknown failure on CTX11.2. I'm still running the CI docker script to see if I can reproduce it, so please do not merge it right now.

@trivialfis trivialfis added bug Something isn't working non-breaking Non-breaking change labels Jun 3, 2021
@trivialfis trivialfis requested a review from a team as a code owner June 3, 2021 16:22
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@df11100). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #3942   +/-   ##
===============================================
  Coverage                ?   85.17%           
===============================================
  Files                   ?      228           
  Lines                   ?    17933           
  Branches                ?        0           
===============================================
  Hits                    ?    15274           
  Misses                  ?     2659           
  Partials                ?        0           
Flag Coverage Δ
dask 47.81% <0.00%> (?)
non-dask 77.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df11100...2a770ba. Read the comment docs.

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Jun 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dc6cb8a into rapidsai:branch-21.06 Jun 3, 2021
@trivialfis trivialfis deleted the bug-disable-det-test-on-ctk11-2 branch June 4, 2021 08:36
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
This reverts part of cb9fbfe due to unknown failure on CTX11.2.  I'm still running the CI docker script to see if I can reproduce it, so please do not merge it right now.

Authors:
  - Jiaming Yuan (https://github.com/trivialfis)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#3942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CUDA/C++ non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants