Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Clang Version to 11.0.0 #4029

Merged
merged 14 commits into from
Jul 9, 2021
Merged

Updating Clang Version to 11.0.0 #4029

merged 14 commits into from
Jul 9, 2021

Conversation

codereport
Copy link
Contributor

Follow up PR to: rapidsai/cudf#6695. Performing the same changes but for rapidsai/cuml

Depends on: rapidsai/integration#304

@codereport codereport requested a review from a team as a code owner July 5, 2021 00:24
@codereport codereport mentioned this pull request Jul 5, 2021
Merged
@codereport codereport requested a review from a team as a code owner July 5, 2021 14:26
@github-actions github-actions bot added the gpuCI gpuCI issue label Jul 5, 2021
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 6, 2021
@codereport
Copy link
Contributor Author

rerun tests

@github-actions github-actions bot removed the gpuCI gpuCI issue label Jul 6, 2021
@codereport
Copy link
Contributor Author

rerun tests

wphicks
wphicks approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over everything in here fairly quickly and don't see any problems from a technical standpoint. The only question I have is whether there should be some cross-team discussion before we standardize on exactly this set of formatting rules. We're reversing or modifying several rules we had in cuML, so I want to make sure that everyone is onboard with that if we're looking to standardize across projects.

I'm giving my approval on the basis of the functional changes here, and I've prompted the cuML folks internally to weigh in if they care about this.

@codereport
Copy link
Contributor Author

rerun tests

5 similar comments
@codereport
Copy link
Contributor Author

rerun tests

@codereport
Copy link
Contributor Author

rerun tests

@ajschmidt8
Copy link
Member

rerun tests

@codereport
Copy link
Contributor Author

rerun tests

@ajschmidt8
Copy link
Member

rerun tests

@wphicks
Copy link
Contributor

wphicks commented Jul 8, 2021 •
edited
Loading

This will not pass until #3990 is in, so no need to rerun tests until that happens and this PR is updated with those changes.

@github-actions github-actions bot added the CMake label Jul 8, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 8, 2021
@codereport codereport requested review from a team as code owners July 8, 2021 18:30
@github-actions github-actions bot added gpuCI gpuCI issue and removed CMake Cython / Python Cython or Python issue labels Jul 8, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@954d7cb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4029   +/-   ##
===============================================
  Coverage                ?   85.46%           
===============================================
  Files                   ?      230           
  Lines                   ?    18139           
  Branches                ?        0           
===============================================
  Hits                    ?    15502           
  Misses                  ?     2637           
  Partials                ?        0
Flag Coverage Δ
dask 48.14% <0.00%> (?)
non-dask 77.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 954d7cb...9f88b39. Read the comment docs.

@cjnolet
Copy link
Member

cjnolet commented Jul 9, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit bcc4cad into rapidsai:branch-21.08 Jul 9, 2021
@vyasr vyasr mentioned this pull request Jul 9, 2021
Closed
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@codereport
Updating Clang Version to 11.0.0 (rapidsai#4029)
1db7e9d 
Follow up PR to: rapidsai/cudf#6695. Performing the same changes but for `rapidsai/cuml`

Depends on: rapidsai/integration#304

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Robert Maynard (https://github.com/robertmaynard)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@dantegd dantegd dantegd approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
CUDA/C++ gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@codereport @ajschmidt8 @wphicks @codecov-commenter @cjnolet @robertmaynard @dantegd