Fix fit_transform on KMeans #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowener
added
3 - Ready for Review
dantegd
requested changes
Jul 15, 2021
| return self.fit(X).transform(X, convert_dtype=convert_dtype, | ||
| sample_weight=sample_weight) | ||
| self.fit(X, sample_weight=sample_weight) | ||
| return self.transform(X, convert_dtype=convert_dtype) |
There was a problem hiding this comment.
Could we add a call/test in one of the pytests?
There was a problem hiding this comment.
I just added a test to cover fit_transform
dantegd
approved these changes
Jul 16, 2021
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Closes rapidsai#4043 Authors: - Micka (https://github.com/lowener) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4043