Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated target_weights in UMAP #4081

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Remove deprecated target_weights in UMAP #4081

merged 1 commit into from
Jul 27, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Jul 22, 2021

Closes #3923

@lowener lowener requested a review from a team as a code owner July 22, 2021 14:43
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 22, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@11088d6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4081   +/-   ##
===============================================
  Coverage                ?   85.74%           
===============================================
  Files                   ?      230           
  Lines                   ?    18186           
  Branches                ?        0           
===============================================
  Hits                    ?    15594           
  Misses                  ?     2592           
  Partials                ?        0
Flag Coverage Δ
dask 48.21% <0.00%> (?)
non-dask 78.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11088d6...16be91a. Read the comment docs.

@lowener lowener added breaking Breaking change bug Something isn't working improvement Improvement / enhancement to an existing function and removed bug Something isn't working labels Jul 26, 2021
@dantegd
Copy link
Member

dantegd commented Jul 27, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 804b5e6 into rapidsai:branch-21.08 Jul 27, 2021
@lowener lowener deleted the 21.08-typo-umap branch July 28, 2021 15:51
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Remove deprecated target_weights in UMAP (rapidsai#4081)
2e6397e 
Closes rapidsai#3923

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
breaking Breaking change Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove target_weights from UMAP parameter in v21.08
3 participants
@lowener @codecov-commenter @dantegd