Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Exposing KL divergence in TSNE #4208

Merged
merged 16 commits into from
Oct 28, 2021
Merged

[REVIEW] Exposing KL divergence in TSNE #4208

merged 16 commits into from
Oct 28, 2021

Conversation

viclafargue
Copy link
Contributor

No description provided.

@viclafargue viclafargue requested review from a team as code owners September 14, 2021 15:37
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Sep 14, 2021
@viclafargue viclafargue added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 28, 2021
@viclafargue viclafargue mentioned this pull request Oct 4, 2021
Closed
@github-actions github-actions bot added the CMake label Oct 5, 2021
@viclafargue viclafargue requested a review from a team as a code owner October 8, 2021 17:18
@github-actions github-actions bot removed the CMake label Oct 8, 2021
@viclafargue viclafargue changed the base branch from branch-21.10 to branch-21.12 October 8, 2021 17:19
@viclafargue viclafargue changed the title [WIP] Exposing KL divergence in TSNE [REVIEW] Exposing KL divergence in TSNE Oct 11, 2021
cjnolet
cjnolet requested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. As usual, mostly minor things.

cpp/src/tsne/barnes_hut_kernels.cuh Outdated Show resolved Hide resolved
cpp/src/tsne/exact_tsne.cuh Outdated Show resolved Hide resolved
cpp/include/cuml/manifold/tsne.h Outdated Show resolved Hide resolved
cpp/src/tsne/cannylab/bh.cu Show resolved Hide resolved
cpp/src/tsne/distances.cuh Show resolved Hide resolved
cpp/src/tsne/fft_kernels.cuh Outdated Show resolved Hide resolved
cpp/src/tsne/tsne.cu Outdated Show resolved Hide resolved
cpp/src/tsne/utils.cuh Outdated Show resolved Hide resolved
cpp/test/sg/tsne_test.cu Outdated Show resolved Hide resolved
cpp/test/sg/tsne_test.cu Show resolved Hide resolved
@viclafargue viclafargue requested a review from a team as a code owner October 25, 2021 15:20
@github-actions github-actions bot added the gpuCI gpuCI issue label Oct 25, 2021
ajschmidt8
ajschmidt8 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

cjnolet
cjnolet requested changes Oct 25, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, Victor, I thought I had submitted the re-review on this and just realized I still had comments pending. 2 very trivial things and I think this initial version is ready to go.

cpp/include/cuml/manifold/tsne.h Outdated Show resolved Hide resolved
cpp/include/cuml/manifold/tsne.h Outdated Show resolved Hide resolved
@viclafargue
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@51c41c4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4208   +/-   ##
===============================================
  Coverage                ?   86.04%           
===============================================
  Files                   ?      231           
  Lines                   ?    18714           
  Branches                ?        0           
===============================================
  Hits                    ?    16103           
  Misses                  ?     2611           
  Partials                ?        0
Flag Coverage Δ
dask 47.00% <0.00%> (?)
non-dask 78.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c41c4...41dc683. Read the comment docs.

cjnolet
cjnolet approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Oct 28, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a7d0300 into rapidsai:branch-21.12 Oct 28, 2021
divyegala pushed a commit to divyegala/cuml that referenced this pull request Oct 29, 2021
@viclafargue @divyegala
Exposing KL divergence in TSNE (rapidsai#4208)
3109400 
Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4208
@dantegd dantegd mentioned this pull request Nov 11, 2021
Closed
@zbjornson zbjornson mentioned this pull request Nov 14, 2021
Merged
zbjornson added a commit to zbjornson/cuml that referenced this pull request Nov 15, 2021
@zbjornson
Fix aliasing violation in t-SNE
b9afa21 
Undefined behavior introduced in rapidsai#4208. These parameters are restrict-qualified, but the callers pass pointers with the same address and the arrays are modified through both pointers.
rapids-bot bot pushed a commit that referenced this pull request Nov 15, 2021
@zbjornson
Fix aliasing violation in t-SNE (#4363)
daa59d5 
Undefined behavior introduced in #4208. These parameters are restrict-qualified, but the callers pass pointers with the same address and the arrays are modified through both pointers.

Authors:
  - Zach Bjornson (https://github.com/zbjornson)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #4363
zbjornson added a commit to zbjornson/cuml that referenced this pull request Dec 6, 2021
@zbjornson
Simplify perplexity normalization in t-SNE
2b02e89 
P_sum is equal to n. See rapidsai#2622 where I made this change once before. rapidsai#4208 changed it back while consolidating code.
@zbjornson zbjornson mentioned this pull request Dec 6, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request Dec 6, 2021
@zbjornson
Simplify perplexity normalization in t-SNE (#4425)
7613d70 
P_sum is equal to n. See #2622 where I made this change once before. #4208 changed it back while consolidating code.

Authors:
  - Zach Bjornson (https://github.com/zbjornson)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #4425
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
Exposing KL divergence in TSNE (rapidsai#4208)
01eaa0c 
Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4208
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@zbjornson
Fix aliasing violation in t-SNE (rapidsai#4363)
1d2b10e 
Undefined behavior introduced in rapidsai#4208. These parameters are restrict-qualified, but the callers pass pointers with the same address and the arrays are modified through both pointers.

Authors:
  - Zach Bjornson (https://github.com/zbjornson)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4363
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@zbjornson
Simplify perplexity normalization in t-SNE (rapidsai#4425)
632cd92 
P_sum is equal to n. See rapidsai#2622 where I made this change once before. rapidsai#4208 changed it back while consolidating code.

Authors:
  - Zach Bjornson (https://github.com/zbjornson)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CUDA/C++ Cython / Python Cython or Python issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viclafargue @codecov-commenter @cjnolet @ajschmidt8