-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for exogenous variables to ARIMA #4221
Add support for exogenous variables to ARIMA #4221
Conversation
Please consider using GitHub's Draft PR feature instead of Some useful information about Draft PRs:
|
@tfeher Thanks for the review. I've made some changes and also added a section to the ARIMA notebook (you might want to have a quick look at this). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Nyrio for fixing the issues. I still need to have a look at the notebook, but otherwise it looks good to me. Pre-approving.
@rapidsai/cuml-python-codeowners for required approval of the Python side of the change. |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #4221 +/- ##
===============================================
Coverage ? 86.01%
===============================================
Files ? 231
Lines ? 18838
Branches ? 0
===============================================
Hits ? 16204
Misses ? 2634
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@Nyrio I had a look at the notebook and the new exogenous variables section looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nyrio Just a small thing with the docstring.
Memory errors in test are tracked in #4370 |
The memory error should be fixed by the last commit. |
Thanks @tfeher ! I completely missed that but it makes sense now. |
@gpucibot merge |
Closes rapidsai#3846 Adds support for exogenous variables to ARIMA. All series in the batch must have the same number of exogenous variables, and exogenous variables are not shared across the batch (`exog` therefore has `n_exog * batch_size` columns). Example: ```python model = ARIMA(endog=df_endog, exog=df_exog_past, order=(1,0,1), seasonal_order=(1,1,1,12), fit_intercept=True, simple_differencing=False) model.fit() fc, lower, upper = model.forecast(40, exog=df_exog_future, level=0.95) ``` ![2021-09-22_exog_fc](https://user-images.githubusercontent.com/17441062/134339807-f815a7a3-98dc-49e5-8599-9607e660597a.png) Authors: - Louis Sugy (https://github.com/Nyrio) - Tamas Bela Feher (https://github.com/tfeher) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Tamas Bela Feher (https://github.com/tfeher) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4221
Closes #3846
Adds support for exogenous variables to ARIMA.
All series in the batch must have the same number of exogenous variables, and exogenous variables are not shared across the batch (
exog
therefore hasn_exog * batch_size
columns).Example: